feat(smart-triggers): Add api handler for smart trigger processing at runtime #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #226
Depends on: cryostatio/cryostat-core#625
Adds an api endpoint (/smart-triggers/) that supports three operations:
GET: Returns the currently registered smart triggers that the agent is aware of
POST: Appends the smart triggers defined by the body to the currently active ones
DELETE: Removes the smart triggers defined by the body from the currently active ones.
Also adds an extra validation method to the trigger parser to check if trigger definitions are valid. This step is done before making any changes to the trigger list or evaluation thread.
Opening as draft pending the accompanying cryostat/web sides.